Discussion:
Intent to unship: mozAutoGainControl & mozNoiseSuppression constraints (and AGC=on by default)
Jan-Ivar Bruaroey
2018-10-10 14:48:36 UTC
Permalink
TL;DR: anticipate very low impact.

We don't have telemetry for these, but we've been warning about these in
web console since 55. [1]

These are legacy names for the standard autoGainControl and
noiseSuppression constraints we've supported since 55. [1]

You can try it out here
https://blog.mozilla.org/webrtc/fiddle-of-the-week-audio-constraints/

Interestingly, in 64 we're also considering changing autoGainControl to
be ON by default (it was the lone audio processing constraint not ON by
default, differing from Chrome). [2]

The way constraints work, specs don't dictate UA defaults. It is up to
JS to constrain all properties they care about. But we wanted to tell
you anyhow.

The most likely net fallout of, if any, would be sites that UA-sniff AND
rely on the legacy Firefox names ONLY to turn OFF audio processing.
These are likely to be specialty sites dealing with things like music
rather than your typical WebRTC communication site. More likely, old
sites would double up the moz and non-moz constraints here in order to
work with both Firefox and Chrome, and in those cases, there is no impact.

[1] https://bugzil.la/1366415
[2] https://bugzil.la/1496714
Mike Taylor
2018-10-10 20:29:25 UTC
Permalink
Hi Jan-Ivar,
Post by Jan-Ivar Bruaroey
The most likely net fallout of, if any, would be sites that UA-sniff AND
rely on the legacy Firefox names ONLY to turn OFF audio processing.
These are likely to be specialty sites dealing with things like music
rather than your typical WebRTC communication site. More likely, old
sites would double up the moz and non-moz constraints here in order to
work with both Firefox and Chrome, and in those cases, there is no impact.
If they didn't include an unprefixed constraint, would it throw?

thanks,
--
Mike Taylor
Web Compat, Mozilla
Jan-Ivar Bruaroey
2018-10-10 21:41:01 UTC
Permalink
Post by Mike Taylor
Hi Jan-Ivar,
Post by Jan-Ivar Bruaroey
The most likely net fallout of, if any, would be sites that UA-sniff
AND rely on the legacy Firefox names ONLY to turn OFF audio
processing. These are likely to be specialty sites dealing with things
like music rather than your typical WebRTC communication site. More
likely, old sites would double up the moz and non-moz constraints here
in order to work with both Firefox and Chrome, and in those cases,
there is no impact.
If they didn't include an unprefixed constraint, would it throw?
No, they'd get processed audio where they expected unprocessed audio.

.: Jan-Ivar :.

Loading...